Bump inlineresources to ^1.2.0.#229
Bump inlineresources to ^1.2.0.#229bernardobelchior wants to merge 2 commits intocburgmer:masterfrom
Conversation
|
Hey, to explain the missing version bump: The commit is there, it just didn't land on master. I've now pushed it (same for inlineresources yesterday). Can I ask you what the pain is that you are solving here?
|
My reasoning is that Not a big deal, though, so feel free to close this PR. |
|
No I understand. If I install rasterizehtml from scratch locally I seem to get the newest version though. That is what you want I understand? |
|
What you of course don't have is the right version in the allinone bundle. I should've stated that earlier. |
Yeah, but if you already had v1.1.0 on your lockfile, it will keep installing v1.1.0 unless you explicitly install v1.2.0.
Yeah, forgot to mention that as well.
As far as I understand, it isn't common to bundle a libraries' dependencies when publishing. It prevents reusing dependencies (e.g., some other library might accept the same version of In my opinion, it would make sense to remove the all in one bundle. It would probably also ease the migration to more modern build tools. If you agree, I can try to tackle it. |
|
Alright, released another version with your changes! If you have time, feel free to provide a new major version without the all-in-one bundle. I've tried updating some of the test dependencies, but it is at least non-trivial. |
|
Thank you! I'll try to tackle it when I have some time 👍 |
Bump inlineresources to ^1.2.0.
Bump package to v1.4.1. v1.4.0 was released in November, and this bump probably warrants a v1.4.1 release.