Skip to content

Commit 5a2f0ee

Browse files
committed
Acknowledge all test without an expectation. Don't make jasmine warn about which was done intentionally
1 parent 4de5407 commit 5a2f0ee

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

test/specs/BrowserSpec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ describe("Browser functions", function () {
262262

263263
it("should deal with a missing 'html' tag", function () {
264264
browser.parseHTML('<div></div>');
265+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
265266
});
266267

267268
it("should correctly set the doctype (see issue #89)", function () {
@@ -298,6 +299,7 @@ describe("Browser functions", function () {
298299

299300
it("should pass on a valid document", function () {
300301
browser.validateXHTML("<b></b>");
302+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
301303
});
302304
});
303305

test/specs/DocumentUtilSpec.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ describe("HTML Document Utility functions", function () {
7979
setHtml('<head><style>@font-face { font-family: "RaphaelIcons"; src: url("raphaelicons-webfont.woff"); }</style></head><body><span></span></body>');
8080

8181
documentUtil.rewriteCssSelectorWith(doc.documentElement, ':hover', '.myFakeHover');
82+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
8283
});
8384

8485
it("should not touch style elements without a matching selector", function () {
@@ -225,6 +226,8 @@ describe("HTML Document Utility functions", function () {
225226

226227
// expect this not to fail (Chrome would complain about the insertion of an invalid selector:
227228
// "SyntaxError: Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule 'esi:include, a { color: blue; }'.")
229+
230+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
228231
});
229232

230233
// Document https://github.com/cburgmer/rasterizeHTML.js/issues/92

test/specs/ProxiesSpec.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,15 @@ describe("XHR Proxies", function () {
9191
finishNotifyingXhrProxy.waitForRequestsToFinish().then(done);
9292

9393
originalXHRInstance[0].mockDone();
94+
95+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
9496
});
9597

9698
it("should finish when no XHR request has been started", function (done) {
9799
var finishNotifyingXhrProxy = proxies.finishNotifyingXhr(xhrMockConstructor);
98100

99101
finishNotifyingXhrProxy.waitForRequestsToFinish().then(done);
102+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
100103
});
101104

102105
it("should notify even if called after all requests resovled", function (done) {
@@ -107,6 +110,7 @@ describe("XHR Proxies", function () {
107110
originalXHRInstance[0].mockDone();
108111

109112
finishNotifyingXhrProxy.waitForRequestsToFinish().then(done);
113+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
110114
});
111115
});
112116

test/specs/Svg2ImageSpec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ describe("Svg to Image", function () {
9393

9494
svg2image.renderSvg("svg", null).then(null, done);
9595
imageSpy.onerror();
96+
expect(true).toBe(true); // work around warning from jasmine that no expectation is given
9697
});
9798

9899
it("should return an image without event listeners attached", function (done) {

0 commit comments

Comments
 (0)