Refactor, reduce reliance on external promise dependency in tests

cburgmer · cburgmer · commit aa438a7a0577 · 2022-01-22T20:25:48.000+01:00
diff --git a/test/specs/indexedDbStorageSpec.js b/test/specs/indexedDbStorageSpec.js
@@ -96,7 +96,7 @@ describe("IndexedDB storage", function () {
         };
 
         var setUpImageForUrlToFail = function (e) {
-            util.getImageForUrl.and.returnValue(testHelper.failedPromise(e));
+            util.getImageForUrl.and.rejectWith(e);
         };
 
         beforeEach(function (done) {
@@ -270,7 +270,7 @@ describe("IndexedDB storage", function () {
         });
 
         it("should call error handler if read reference image is invalid", function (done) {
-            setUpImageForUrlToFail();
+            setUpImageForUrlToFail(new Error("blargh"));
 
             storeMockReferenceImage(
                 "somePage.html",
@@ -280,7 +280,9 @@ describe("IndexedDB storage", function () {
             );
             storage
                 .readReferenceImage({ url: "somePage.html" })
-                .then(null, done);
+                .then(null, function () {
+                    done();
+                });
         });
 
         it("should honour test case parameters when reading", function (done) {
diff --git a/test/testHelper.js b/test/testHelper.js
@@ -25,12 +25,6 @@ window.testHelper = (function () {
         });
     };
 
-    module.failedPromise = function (e) {
-        var defer = ayepromise.defer();
-        defer.reject(e);
-        return defer.promise;
-    };
-
     module.deferFake = function (value) {
         var successHandler,
             resolved = false;
