Disable test which compares two images until we find a stable way of doing that across browsers

cburgmer · cburgmer · commit c075b315da14 · 2022-01-21T21:06:57.000+01:00
diff --git a/test/smokeTest.js b/test/smokeTest.js
@@ -7,7 +7,7 @@ const fs = require("fs");
 const http = require("http");
 const puppeteer = require("puppeteer");
 
-const webserverPort = 8000;
+const webserverPort = 8099;
 
 if (process.argv.length !== 3) {
     console.log("Usage: smokeTest.js csscriticLoadingHtmlPage");
diff --git a/test/specs/.jshintrc b/test/specs/.jshintrc
@@ -5,6 +5,7 @@
         "jasmine": true,
         "describe": true,
         "it": true,
+        "xit": true,
         "beforeEach": true,
         "afterEach": true,
         "runs": true,
diff --git a/test/specs/integrationSpec.js b/test/specs/integrationSpec.js
@@ -197,43 +197,39 @@ describe("Integration", function () {
         }
     );
 
-    ifNotInWebkitIt(
-        "should store a reference when a result is accepted",
-        function (done) {
-            var testPageUrl = testHelper.fixture("pageUnderTest.html"),
-                reporter = jasmine.createSpyObj("Reporter", [
-                    "reportComparison",
-                ]);
+    // Disabled, as we cannot compare the serialized image across browsers. Same image has different serialisations
+    xit("should store a reference when a result is accepted", function (done) {
+        var testPageUrl = testHelper.fixture("pageUnderTest.html"),
+            reporter = jasmine.createSpyObj("Reporter", ["reportComparison"]);
 
-            csscritic.addReporter(reporter);
-            csscritic.add(testPageUrl);
-            csscritic.execute().then(function (passed) {
-                expect(passed).toBe(false);
-                expect(reporter.reportComparison).toHaveBeenCalledWith(
-                    jasmine.any(Object)
-                );
-
-                reporter.reportComparison.calls
-                    .mostRecent()
-                    .args[0].resizePageImage(330, 151)
-                    .then(function () {
-                        reporter.reportComparison.calls
-                            .mostRecent()
-                            .args[0].acceptPage();
-
-                        readReferenceImage(testPageUrl).then(function (
-                            referenceObj
-                        ) {
-                            expect(referenceObj.imageUri).toEqual(
-                                theReferenceImageUri
-                            );
-
-                            done();
-                        });
+        csscritic.addReporter(reporter);
+        csscritic.add(testPageUrl);
+        csscritic.execute().then(function (passed) {
+            expect(passed).toBe(false);
+            expect(reporter.reportComparison).toHaveBeenCalledWith(
+                jasmine.any(Object)
+            );
+
+            reporter.reportComparison.calls
+                .mostRecent()
+                .args[0].resizePageImage(330, 151)
+                .then(function () {
+                    reporter.reportComparison.calls
+                        .mostRecent()
+                        .args[0].acceptPage();
+
+                    readReferenceImage(testPageUrl).then(function (
+                        referenceObj
+                    ) {
+                        expect(referenceObj.imageUri).toEqual(
+                            theReferenceImageUri
+                        );
+
+                        done();
                     });
-            });
-        }
-    );
+                });
+        });
+    });
 
     ifNotInWebkitIt(
         "should properly report a failing comparison",
